Update Pandora track and shower discrimination scheme and training#840
Open
Update Pandora track and shower discrimination scheme and training#840
Conversation
| <UseICARUSCollectionPlane>true</UseICARUSCollectionPlane> | ||
| <MvaFileName>PFOCharBDT_v09_84_00_03_20250718_ICARUSCollection.xml</MvaFileName> | ||
| <MvaName>PFOCharBDT_v09_84_00_03_20250718_ICARUSCollection</MvaName> | ||
| <MvaFileNameNoChargeInfo>PFOCharBDT_v09_84_00_03_20250718_NoCharge.xml</MvaFileNameNoChargeInfo> |
Contributor
There was a problem hiding this comment.
Just curious - why are these in a separate file instead of putting both into one file as before? (wondering if just a choice or if there is a particular reason e.g.)
Also: checking, in the doc-db presentation you've given with the training results, were they prepared with these changes, so in some way this is already validated?
Author
There was a problem hiding this comment.
The two BDTs (with charge information and without it) came from two separate trainings, so I saved them into two separate XMLs. If you think it would be nicer to have them within a single XML, I can merge them! Thanks Bruce!
Contributor
There was a problem hiding this comment.
I think it's probably fine either way.
brucehoward-physics
approved these changes
Aug 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the Pandora XML (particularly, the
LArBdtPfoCharacterisationalgorithm) to accomodate for changes to the track/shower discrimination scheme, and to introduce the corresponding new BDT training files.Context
The code change within Pandora consists in choosing the Collection plane to compute calorimetric variables used in the track/shower discrimination BDT, instead of relying on the Induction-1 plane. Due to mapping technicalities, the Pandora
Wview (commonly mapped to Collection in other LArTPCs) is mapped to Induction-1 in ICARUS, whereas theUandVviews are mapped to Induction-2 or Collection, based on the TPC. For more details on the Pandora code change, check the corresponding PandoraPFA/LArContent PR #246, SBN DocDB 40882, and SBN DocDB 40375.The
UseICARUSCollectionPlanealgorithm parameter controls the plane used to determine whether charge information is available or not for the reconstructed particle (Collection iftrue), and as a result which BDT to use.Two ICARUS-specific tools are defined:
ConeChargeFeatureTool_ICARUS, andThreeDChargeFeatureTool_ICARUS. TheUseICARUSCollectionPlanetool parameter controls the plane used for computing charge-based variables (Collection iftrue).This modification was agreed with Pandora experts.
BDT re-training
Information on the BDT re-training are available on SBN DocDB 42432.
The track/shower BDT was re-trained with BNB MC samples based on
icaruscodev09_84_00_01, balanced between track and shower particles, and with "good reconstruction" cuts. The accuracy of the classification is shown to improve substantially across all particle types.Dependency
This PR needs the LArSoft/
larpandoracontentv04_16_00 release (LArSoft/larpandoracontent PR #78), i.e.,larsoftv10_08_02.It also needs the corresponding BDT XMLs added to
icarus_data: a newicarus_datarelease will be needed to pick up the right XMLs.After this PR is merged, the CAFMaker needs to be updated to pick up the newly-named tools. A companion PR in
sbncodewas opened (sbncode PR #546).Review
Tagging for review:
Also tagging @acampani as assignee.
Thanks!